[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/12] compiler: never omit assertions if using a sta
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 04/12] compiler: never omit assertions if using a static analysis tool |
Date: |
Tue, 19 Jul 2016 10:34:11 +0200 |
Assertions help both Coverity and the clang static analyzer avoid
false positives, but on the other hand both are confused when
the condition is compiled as (void)(x != FOO). Always expand
assertion macros when using Coverity or clang, through a new
QEMU_STATIC_ANALYSIS preprocessor symbol.
This fixes a couple false positives in TCG.
Signed-off-by: Paolo Bonzini <address@hidden>
---
include/qemu/compiler.h | 3 +++
tcg/tcg.h | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
index b64f899..338d3a6 100644
--- a/include/qemu/compiler.h
+++ b/include/qemu/compiler.h
@@ -3,6 +3,9 @@
#ifndef COMPILER_H
#define COMPILER_H
+#if defined __clang_analyzer__ || defined __COVERITY__
+#define QEMU_STATIC_ANALYSIS 1
+#endif
/*----------------------------------------------------------------------------
| The macro QEMU_GNUC_PREREQ tests for minimum version of the GNU C compiler.
diff --git a/tcg/tcg.h b/tcg/tcg.h
index 66ae0c7..6046dcd 100644
--- a/tcg/tcg.h
+++ b/tcg/tcg.h
@@ -191,7 +191,7 @@ typedef uint64_t tcg_insn_unit;
#endif
-#ifdef CONFIG_DEBUG_TCG
+#if defined CONFIG_DEBUG_TCG || defined QEMU_STATIC_ANALYSIS
# define tcg_debug_assert(X) do { assert(X); } while (0)
#elif QEMU_GNUC_PREREQ(4, 5)
# define tcg_debug_assert(X) \
--
2.7.4
- [Qemu-devel] [PULL v2 00/12] Misc patches for 2.7 hard freeze from 2016-07-18, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 02/12] Changed malloc to g_malloc, free to g_free in bsd-user/qemu.h, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 01/12] use g_path_get_dirname instead of dirname, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 05/12] megasas: remove useless check for cmd->frame, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 03/12] hw/i386: add device tree support, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 04/12] compiler: never omit assertions if using a static analysis tool,
Paolo Bonzini <=
- [Qemu-devel] [PULL 08/12] cpu-exec: Move down some declarations in cpu_exec(), Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 07/12] exec: avoid realloc in phys_map_node_reserve, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 10/12] block/iscsi: fix rounding in iscsi_allocationmap_set, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 09/12] Move README to markdown, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 06/12] checkpatch: consider git extended headers valid patches, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 12/12] target-i386: Remove redundant HF_SOFTMMU_MASK, Paolo Bonzini, 2016/07/19
- [Qemu-devel] [PULL 11/12] block/iscsi: allow caching of the allocation map, Paolo Bonzini, 2016/07/19