[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 09/10] target-avr: updating translate.c to u
From: |
Michael Rolnik |
Subject: |
Re: [Qemu-devel] [PATCH v10 09/10] target-avr: updating translate.c to use instructions translation |
Date: |
Tue, 19 Jul 2016 07:22:57 -0700 |
Hello,
I fixed all the issue, the patches were sent last week (July 6th). Please
have a look.
regards,
Michael
On Wed, Jul 13, 2016 at 12:21 AM, Richard Henderson <address@hidden> wrote:
> On 07/12/2016 08:49 PM, Michael Rolnik wrote:
>
>> if I fold this patch into previous ones, they will become non buildable,
>> because this patch assumes existance of functions from the preceding
>> patch.
>> Is this acceptable?
>>
>
> All patches need to be buildable, so that git bisect works.
>
> The previous patches are already (sort of) non-buildable, but you don't
> notice because you've not added translate-inst.o to obj-y until here. But
> there's certainly no reason to put code in translate.c in one patch, then
> move it to translate.h in another.
>
>
> r~
>
--
Best Regards,
Michael Rolnik
- Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added., (continued)
- [Qemu-devel] [PATCH v10 05/10] target-avr: adding AVR interrupt handling, Michael Rolnik, 2016/07/06
- [Qemu-devel] [PATCH v10 06/10] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions, Michael Rolnik, 2016/07/06
- [Qemu-devel] [PATCH v10 04/10] target-avr: adding instructions encodings, Michael Rolnik, 2016/07/06
- [Qemu-devel] [PATCH v10 07/10] target-avr: adding instruction decoder, Michael Rolnik, 2016/07/06
- [Qemu-devel] [PATCH v10 09/10] target-avr: updating translate.c to use instructions translation, Michael Rolnik, 2016/07/06
[Qemu-devel] [PATCH v10 10/10] target-avr: instruction decoder generator, Michael Rolnik, 2016/07/06
[Qemu-devel] [PATCH v10 08/10] target-avr: adding instruction translation, Michael Rolnik, 2016/07/06