qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v10 09/10] target-avr: updating translate.c to u


From: Michael Rolnik
Subject: Re: [Qemu-devel] [PATCH v10 09/10] target-avr: updating translate.c to use instructions translation
Date: Tue, 19 Jul 2016 07:22:57 -0700

Hello,

I fixed all the issue, the patches were sent last week (July 6th). Please
have a look.

regards,
Michael

On Wed, Jul 13, 2016 at 12:21 AM, Richard Henderson <address@hidden> wrote:

> On 07/12/2016 08:49 PM, Michael Rolnik wrote:
>
>> if I fold this patch into previous ones, they will become non buildable,
>> because this patch assumes existance of functions from the preceding
>> patch.
>> Is this acceptable?
>>
>
> All patches need to be buildable, so that git bisect works.
>
> The previous patches are already (sort of) non-buildable, but you don't
> notice because you've not added translate-inst.o to obj-y until here.  But
> there's certainly no reason to put code in translate.c in one patch, then
> move it to translate.h in another.
>
>
> r~
>



-- 
Best Regards,
Michael Rolnik


reply via email to

[Prev in Thread] Current Thread [Next in Thread]