[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema |
Date: |
Wed, 20 Jul 2016 17:40:39 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Jul 20, 2016 at 03:24:41PM -0600, Eric Blake wrote:
> On 07/19/2016 06:21 PM, Jeff Cody wrote:
> > From: Prasanna Kumar Kalever <address@hidden>
> >
> > this patch adds 'GlusterServer' related schema in qapi/block-core.json
> >
> > [Jeff: minor fix-ups of comments and formatting, per patch reviews]
> >
> > Signed-off-by: Prasanna Kumar Kalever <address@hidden>
> > Reviewed-by: Markus Armbruster <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
> > Message-id: address@hidden
> > Signed-off-by: Jeff Cody <address@hidden>
> > ---
>
> > +++ b/qapi/block-core.json
> > @@ -1666,13 +1666,14 @@
>
> > +##
> > +# @BlockdevOptionsGluster
> > +#
> > +# Driver specific block device options for Gluster
> > +#
> > +# @volume: name of gluster volume where VM image resides
> > +#
> > +# @path: absolute path to image file in gluster volume
> > +#
> > +# @server: gluster server description
> > +#
> > +# @debug-level: #optional libgfapi log level (default '4' which is Error)
>
> You got one,
>
> > +#
> > +# Since: 2.7
> > +##
> > +{ 'struct': 'BlockdevOptionsGluster',
> > + 'data': { 'volume': 'str',
> > + 'path': 'str',
> > + 'server': 'GlusterServer',
> > + '*debug_level': 'int' } }
>
> but not the other instance. Can be fixed in a followup patch if the pull
> request has already landed.
>
Oops, sorry Eric, missed that fix-up when applying. Therein lies the danger
of maintainer-applied fixes.
Yes, I believe these are now in master, so I'll a send patch to fix it for
-rc1. Thanks for catching it.
-Jeff
- [Qemu-devel] [PULL 06/14] mirror: optimize dirty bitmap filling in mirror_run a bit, (continued)
- [Qemu-devel] [PULL 06/14] mirror: optimize dirty bitmap filling in mirror_run a bit, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 08/14] mirror: improve performance of mirroring of empty disk, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 07/14] mirror: efficiently zero out target, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 09/14] mirror: fix request throttling in drive-mirror, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 10/14] block/gluster: rename [server, volname, image] -> [host, volume, path], Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 11/14] block/gluster: code cleanup, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 12/14] block/gluster: deprecate rdma support, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 14/14] block/gluster: add support for multiple gluster servers, Jeff Cody, 2016/07/19
- [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema, Jeff Cody, 2016/07/19
- Re: [Qemu-devel] [PULL 00/14] Block patches, Peter Maydell, 2016/07/20