[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] iotest: fix python based IO tests
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2] iotest: fix python based IO tests |
Date: |
Tue, 26 Jul 2016 18:29:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 26.07.2016 18:16, Daniel P. Berrange wrote:
> The previous commit refactoring iotests.py:
>
> commit 66613974468fb6e1609fb3eabf55981b1ee436cf
> Author: Daniel P. Berrange <address@hidden>
> Date: Wed Jul 20 14:23:10 2016 +0100
>
> scripts: refactor the VM class in iotests for reuse
>
> was not properly tested and included a number of broken
> bits.
>
> - The 'event_match' method was not moved into qemu.py
> - The 'self._args' list parameter in QEMUMachine needs
> to be copied otherwise modifications will affect the
> global 'qemu_opts' variable in iotests.py
> - The QEMUQtestMachine class methods had inverted
> parameter order for the super() calls
> - The QEMUQtestMachine class forgot to add
> '-machine accel=qtest'
> - The QEMUQtestMachine class constructor needs to set
> a default 'name' value before using it as it may
> be None
> - The QEMUQtestMachine class constructor needs to use
> named parameters when calling the super constructor
> as it is leaving out some positional parameters.
> - The 'qemu_prog' variable should be a string not a
> list in iotests.py
> - The VM classs constructor needs to use named
> parameters when calling the super constructor
> as it is leaving out some positional parameters.
> - The path to the socket-scm-helper needs to be
> passed into the QEMUMachine class
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> scripts/qemu.py | 32 ++++++++++++++++++++++++++------
> scripts/qtest.py | 19 ++++++++++++-------
> tests/qemu-iotests/iotests.py | 24 ++++--------------------
> 3 files changed, 42 insertions(+), 33 deletions(-)
Thanks, replaced v1 in my queue with this v2:
https://github.com/XanClic/qemu/commits/block
Max
signature.asc
Description: OpenPGP digital signature