[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] util: Drop inet_listen()
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] util: Drop inet_listen() |
Date: |
Wed, 27 Jul 2016 12:36:25 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Mon, Jul 25, 2016 at 09:02:51PM +0800, Cao jin wrote:
> Since commit e65c67e4, inet_listen() is not used anymore, and all
> inet listen operation goes through QIOChannel.
>
> Cc: Daniel P. Berrange <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Eric Blake <address@hidden>
>
> Signed-off-by: Cao jin <address@hidden>
> ---
> include/qemu/sockets.h | 2 --
> util/qemu-sockets.c | 28 ----------------------------
> 2 files changed, 30 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
> diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
> index 28a28c0..9eb2470 100644
> --- a/include/qemu/sockets.h
> +++ b/include/qemu/sockets.h
> @@ -33,8 +33,6 @@ int socket_set_fast_reuse(int fd);
> typedef void NonBlockingConnectHandler(int fd, Error *err, void *opaque);
There's still scope for a 3rd patch to remove this NonBlockingConnectHandler
typedef, since nothing uses it anymore.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|