[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.7 v4 05/36] qga: free remaining leaking st
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-2.7 v4 05/36] qga: free remaining leaking state |
Date: |
Fri, 05 Aug 2016 13:26:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Copying maintainer.
address@hidden writes:
> From: Marc-André Lureau <address@hidden>
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> qga/guest-agent-command-state.c | 6 ++++++
> qga/guest-agent-core.h | 1 +
> qga/main.c | 6 ++++++
> 3 files changed, 13 insertions(+)
>
> diff --git a/qga/guest-agent-command-state.c b/qga/guest-agent-command-state.c
> index 4de229c..e609d32 100644
> --- a/qga/guest-agent-command-state.c
> +++ b/qga/guest-agent-command-state.c
> @@ -71,3 +71,9 @@ GACommandState *ga_command_state_new(void)
> cs->groups = NULL;
> return cs;
> }
> +
> +void ga_command_state_free(GACommandState *cs)
> +{
> + g_slist_free_full(cs->groups, g_free);
> + g_free(cs);
> +}
> diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
> index 0a49516..63e9d39 100644
> --- a/qga/guest-agent-core.h
> +++ b/qga/guest-agent-core.h
> @@ -28,6 +28,7 @@ void ga_command_state_add(GACommandState *cs,
> void ga_command_state_init_all(GACommandState *cs);
> void ga_command_state_cleanup_all(GACommandState *cs);
> GACommandState *ga_command_state_new(void);
> +void ga_command_state_free(GACommandState *cs);
> bool ga_logging_enabled(GAState *s);
> void ga_disable_logging(GAState *s);
> void ga_enable_logging(GAState *s);
> diff --git a/qga/main.c b/qga/main.c
> index bb48214..0b9d04e 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -1371,6 +1371,8 @@ int main(int argc, char **argv)
> end:
> if (s->command_state) {
> ga_command_state_cleanup_all(s->command_state);
> + ga_command_state_free(s->command_state);
> + json_message_parser_destroy(&s->parser);
> }
> if (s->channel) {
> ga_channel_free(s->channel);
> @@ -1383,6 +1385,10 @@ end:
> }
>
> config_free(config);
> + if (s->main_loop) {
> + g_main_loop_unref(s->main_loop);
> + }
> + g_free(s);
>
> return ret;
> }
- [Qemu-devel] [PATCH for-2.7 v4 00/36] Various memory leak fixes, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 01/36] build-sys: fix building with make CFLAGS=.. argument, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 02/36] tests: fix test-qga leaks, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 03/36] glib-compat: add g_(s)list_free_full(), marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 04/36] qga: free the whole blacklist, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 05/36] qga: free remaining leaking state, marcandre . lureau, 2016/08/05
- Re: [Qemu-devel] [PATCH for-2.7 v4 05/36] qga: free remaining leaking state,
Markus Armbruster <=
- [Qemu-devel] [PATCH for-2.7 v4 06/36] tests: fix test-cutils leaks, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 07/36] tests: fix test-vmstate leaks, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 08/36] tests: fix test-iov leaks, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 09/36] tests: fix check-qom-interface leaks, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 10/36] tests: fix check-qom-proplist leaks, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 11/36] tests: fix small leak in test-io-channel-command, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 12/36] tests: fix leak in test-string-input-visitor, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 13/36] portio: keep references on portio, marcandre . lureau, 2016/08/05
- [Qemu-devel] [PATCH for-2.7 v4 14/36] numa: do not leak NumaOptions, marcandre . lureau, 2016/08/05