qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 10/12] monitor: use qmp_dispatch()


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 10/12] monitor: use qmp_dispatch()
Date: Fri, 05 Aug 2016 16:43:33 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

address@hidden writes:

> From: Marc-André Lureau <address@hidden>
>
> Replace the old manual dispatch and validation code by the generic one
> provided by qapi common code.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  monitor.c    | 319 
> +++++++----------------------------------------------------
>  trace-events |   1 -
>  2 files changed, 34 insertions(+), 286 deletions(-)

All right, this is where it gets interesting: you replace a whole bunch
of code by other code we have anyway.  Excellent.  Only we need to
convince ourselves the replacement is functionally equivalent.  Before I
dive into that, what have you done to convince yourself?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]