|
From: | Nikunj A Dadhania |
Subject: | Re: [Qemu-devel] [PATCH 2/6] target-ppc: Implement darn instruction |
Date: | Mon, 08 Aug 2016 11:50:27 +0530 |
User-agent: | Notmuch/0.21 (https://notmuchmail.org) Emacs/25.0.94.1 (x86_64-redhat-linux-gnu) |
Richard Henderson <address@hidden> writes: > On 08/07/2016 11:06 PM, Nikunj A Dadhania wrote: >> +target_ulong helper_darn(uint32_t l) >> +{ >> + target_ulong r = UINT64_MAX; >> + >> + if (l <= 2) { >> + do { >> + r = random() * random(); >> + r &= l ? UINT64_MAX : UINT32_MAX; >> + } while (r == UINT64_MAX); >> + } >> + >> + return r; >> +} > > Without considering the rng, I think you should split this into darn32 and > darn64 based on L in translate.c. You can diagnose l==2 in translate.c as > well. Sure. Regards Nikunj
[Prev in Thread] | Current Thread | [Next in Thread] |