Re: [Qemu-devel] [PATCH v1] docs: add cpu-hotplug.txt

[Dou Liyang]

Hi Fam,

在 2016年08月09日 15:14, Fam Zheng 写道:
> Hello Liyang, Thanks for the contribution!
>
> On Tue, 08/09 14:48, Dou Liyang wrote:
> > This document describes how to use cpu hotplug in QEMU.
> >
> > Change log v1:
> >   From Igor's advice:
> >     1. Remove any mentioning of apic-id from the document.
> >     2. Remove the "device_del qom_path" from the CPU hot-unplug.
> >     3. Fix some comment.
>
> In the future, please put the revision log after the "---" line below your
> signed-off-by line, so that it doesn't get committed to the git history (this
> information is not useful there) once get merged.
>
> I'm not a native English speaker either, but I'll try to give some suggestions
> on the documentation below. Please don't mind, and take with a grain of salt.  
> :)

Thank you very much for your advice. They are very helpful for me. :)

> > Signed-off-by: Dou Liyang <address@hidden>
> > ---
> >  docs/cpu-hotplug.txt | 124 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 124 insertions(+)
> >  create mode 100644 docs/cpu-hotplug.txt
> >
> > diff --git a/docs/cpu-hotplug.txt b/docs/cpu-hotplug.txt
> > new file mode 100644
> > index 0000000..2c51e27
> > --- /dev/null
> > +++ b/docs/cpu-hotplug.txt
> > @@ -0,0 +1,124 @@
> > +QEMU CPU hotplug
> > +===================

> > +For example, assuming that the cpu device with id "cpu1" exists,
> > +the following commands tries to remove it.
>
> s/commands/command/
>
> > +
> > +  (qemu) device_del cpu1
> > +
>
> Can you also document what should be done in guest to make this operation
> successful?

I am not sure about these words "what should be done in guest".

Do you mean that setting the CPUx's online to 1 to make the CPUx
online? or anything else?

> Fam

Thanks,

Dou Liyang