[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch() |
Date: |
Tue, 9 Aug 2016 13:48:14 +0100 |
User-agent: |
Mutt/1.6.2 (2016-07-01) |
On Tue, Aug 09, 2016 at 02:43:41PM +0200, Markus Armbruster wrote:
> address@hidden writes:
>
> > From: Marc-André Lureau <address@hidden>
> >
> > Replace the old manual dispatch and validation code by the generic one
> > provided by qapi common code.
> >
> > Note that it is now possible to call the following commands that used to
> > be disabled by compile-time conditionals:
> > - dump-skeys
> > - query-spice
> > - rtc-reset-reinjection
> > - query-gic-capabilities
> >
> > Their fallback functions return an appropriate "feature disabled" error.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
>
> Means query-qmp-schema no longer shows whether these commands are
> supported, doesn't it?
>
> Eric, could this create difficulties for libvirt or other introspection
> users?
Libvirt doesn't use query-qmp-schema at all - we just blindly invoke
the commands and catch error. That said I agree with your point though.
It seems pretty undesirable for query-qmp-schema to report that the
commands exist when they clearly don't really exist in any usable
manner.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v3 07/15] monitor: remove mhandler.cmd_new, (continued)
- [Qemu-devel] [PATCH v3 07/15] monitor: remove mhandler.cmd_new, marcandre . lureau, 2016/08/08
- [Qemu-devel] [PATCH v3 08/15] monitor: implement 'qmp_query_commands' without qmp_cmds, marcandre . lureau, 2016/08/08
- [Qemu-devel] [PATCH v3 09/15] qapi: remove the "middle" mode, marcandre . lureau, 2016/08/08
- [Qemu-devel] [PATCH v3 10/15] qapi: check invalid arguments on no-args commands, marcandre . lureau, 2016/08/08
- [Qemu-devel] [PATCH v3 11/15] qmp: update qmp_query_spice fallback, marcandre . lureau, 2016/08/08
- [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), marcandre . lureau, 2016/08/08
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Markus Armbruster, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(),
Daniel P. Berrange <=
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Marc-André Lureau, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Markus Armbruster, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Marc-André Lureau, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Markus Armbruster, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Marc-André Lureau, 2016/08/09
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Markus Armbruster, 2016/08/10
- Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch(), Marc-André Lureau, 2016/08/10
[Qemu-devel] [PATCH v3 13/15] build-sys: remove qmp-commands-old.h, marcandre . lureau, 2016/08/08
[Qemu-devel] [PATCH v3 15/15] qmp-commands.txt: fix some styling, marcandre . lureau, 2016/08/08
[Qemu-devel] [PATCH v3 14/15] Drop qmp-commands.hx, marcandre . lureau, 2016/08/08