[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.8 v1 11/60] trace: remove use of event ID
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for-2.8 v1 11/60] trace: remove use of event ID enums from APIs |
Date: |
Tue, 9 Aug 2016 18:18:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/08/2016 17:31, Daniel P. Berrange wrote:
> Since there will shortly be multiple event groups allowed,
> we can no longer use the TraceEventID and TraceEventVCPUID
> enums in the trace control APIs. There will in fact be
> multiple distinct enums, and the enum values will only be
> required to be unique per group.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> trace/control-internal.h | 14 +++++++-------
> trace/control-target.c | 6 +++---
> trace/control.h | 25 ++++++-------------------
> trace/event-internal.h | 4 ++--
> trace/simple.c | 6 +++---
> trace/simple.h | 2 +-
> 6 files changed, 22 insertions(+), 35 deletions(-)
>
> diff --git a/trace/control-internal.h b/trace/control-internal.h
> index 634effe..b7048d4 100644
> --- a/trace/control-internal.h
> +++ b/trace/control-internal.h
> @@ -24,13 +24,13 @@ static inline bool trace_event_is_pattern(const char *str)
> return strchr(str, '*') != NULL;
> }
>
> -static inline TraceEventID trace_event_get_id(TraceEvent *ev)
> +static inline size_t trace_event_get_id(TraceEvent *ev)
> {
> assert(ev != NULL);
> return ev->id;
Perhaps "unsigned" is a better match than size_t?
Paolo
- [Qemu-devel] [PATCH for-2.8 v1 07/60] trace: remove some now unused functions, (continued)
- [Qemu-devel] [PATCH for-2.8 v1 07/60] trace: remove some now unused functions, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 04/60] trace: move hw/virtio/virtio-balloon.c trace points into correct file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 05/60] trace: add trace event iterator APIs, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 03/60] trace: move hw/mem/pc-dimm.c trace points into correct file, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 06/60] trace: convert code to use event iterators, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 08/60] trace: provide mechanism for registering trace events, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 09/60] trace: remove use of TRACE_VCPU_EVENT_COUNT in cpu.h, Daniel P. Berrange, 2016/08/09
- [Qemu-devel] [PATCH for-2.8 v1 11/60] trace: remove use of event ID enums from APIs, Daniel P. Berrange, 2016/08/09
- Re: [Qemu-devel] [PATCH for-2.8 v1 11/60] trace: remove use of event ID enums from APIs,
Paolo Bonzini <=
- [Qemu-devel] [PATCH for-2.8 v1 10/60] trace: remove fixed global event state arrays, Daniel P. Berrange, 2016/08/09
[Qemu-devel] [PATCH for-2.8 v1 12/60] trace: use -1 instead of TRACE_VCPU_EVENT_COUNT as magic value, Daniel P. Berrange, 2016/08/09
[Qemu-devel] [PATCH for-2.8 v1 14/60] trace: get rid of generated-events.h/generated-events.c, Daniel P. Berrange, 2016/08/09
[Qemu-devel] [PATCH for-2.8 v1 13/60] trace: remove generated-events.h from many includes, Daniel P. Berrange, 2016/08/09
[Qemu-devel] [PATCH for-2.8 v1 19/60] trace: switch util/ directory to modular trace.h file, Daniel P. Berrange, 2016/08/09