Re: [Qemu-devel] [PATCH] checkpatch: allow tabs in linux-headers

[Paolo Bonzini]

On 09/08/2016 18:37, Radim Krčmář wrote:
>>> Make scripts/checkpatch.pl accept tabs in linux-headers/, instead of
>>> changing scripts/update-linux-headers.sh to expand tabs when importing.
>>>
>>> Signed-off-by: Radim Krčmář <address@hidden>
>>> ---
>>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>>> index 929708721299..38232d4b25c3 100755
>>> --- a/scripts/checkpatch.pl
>>> +++ b/scripts/checkpatch.pl
>>> @@ -1355,7 +1355,7 @@ sub process {
>>>             next if ($realfile !~ /\.(h|c|cpp|pl)$/);
>>>  
>>>  # in QEMU, no tabs are allowed
>>> -           if ($rawline =~ /^\+.*\t/) {
>>> +           if ($rawline =~ /^\+.*\t/ && $realfile !~ /^linux-headers\//) {
>>>                     my $herevet = "$here\n" . cat_vet($rawline) . "\n";
>>>                     ERROR("code indent should never use tabs\n" . $herevet);
>>>                     $rpt_cleaners = 1;
>>>
>>
>> Could you do the same for standard-headers/ too?
> 
> Sure, and when we are at it ... are *.pl files going to be reindented?
> 
> e.g. checkpatch.pl uses tabs consistently, get_maintainer.pl is a
> horrible mix of tabs and spaces [1], and clean-header-guards.pl uses 4
> spaces for an indent.

I've sent a patch series to fix the most obvious issues in automated
checkpatch email, it skips the tab check on imported Perl scripts.

Paolo