[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] checkpatch: bump most warnings to errors
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] checkpatch: bump most warnings to errors |
Date: |
Wed, 10 Aug 2016 06:25:02 -0400 (EDT) |
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 714a000..ab08ca2 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1289,11 +1289,11 @@ sub process {
> > # This is a signoff, if ugly, so do not double report.
> > $signoff++;
> > if (!($line =~ /^\s*Signed-off-by:/)) {
> > - WARN("Signed-off-by: is the preferred form\n" .
> > + ERROR("Signed-off-by: is the preferred form\n" .
> > $herecurr);
> > }
>
> If you turn this into an ERROR, it's not the "preferred form" anymore,
> but the "mandated form". So I'd suggest to either keep it as WARN or to
> rephrase the message.
What about:
ERROR("Signed-off-by: is spelled with uppercase
\"s\"\n" .
$herecurr);
Paolo
Re: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks, Markus Armbruster, 2016/08/10
Re: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks, no-reply, 2016/08/10
Re: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks, no-reply, 2016/08/10