qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 01/10] target-ppc: add xxspltib instruction


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v1 01/10] target-ppc: add xxspltib instruction
Date: Thu, 11 Aug 2016 23:28:26 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 08/10/2016 08:00 PM, Nikunj A Dadhania wrote:
+#if defined(TARGET_PPC64)
+#define pattern(x) (((x) & 0xff) * (~(target_ulong)0 / 0xff))
+
+static void gen_xxspltib(DisasContext *ctx)
...
+    tcg_gen_movi_i64(cpu_vsrh(xT(ctx->opcode)), pattern(uim8));

Is this function really not available in 32-bit mode?

I'd been pointing out that you should change target_ulong in PATTERN, above, to uint64_t, so that you match tcg_gen_movi_i64.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]