Re: [Qemu-devel] [PATCH v3 06/10] palmetto-bmc: add board specific configuration

[Cédric Le Goater]

On 08/11/2016 12:27 PM, Peter Maydell wrote:
> On 2 August 2016 at 18:15, Cédric Le Goater <address@hidden> wrote:
>> aspeed_board_init() now uses a board identifier to customize some values
>> specific to the board.
>>
>> Signed-off-by: Cédric Le Goater <address@hidden>
>> ---
>>
>>  Changes since v2:
>>
>>  - removed silicon-rev and cpu-model. This is now in the SoC.
>>
>>  Changes since v1:
>>
>>  - changed aspeed_init() prototype to use a 'const AspeedBoardConfig *'
>>  - fixed white space issues
>>
>>  hw/arm/aspeed.c | 22 ++++++++++++++++++----
>>  1 file changed, 18 insertions(+), 4 deletions(-)
>>
>> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
>> index ad0a062b5624..4226b8dcd95c 100644
>> --- a/hw/arm/aspeed.c
>> +++ b/hw/arm/aspeed.c
>> @@ -30,6 +30,19 @@ typedef struct AspeedBoardState {
>>      MemoryRegion ram;
>>  } AspeedBoardState;
>>
>> +typedef struct AspeedBoardConfig {
>> +    const char *soc_name;
>> +    uint32_t hw_strap1;
>> +} AspeedBoardConfig;
>> +
>> +enum {
>> +    PALMETTO_BMC
> 
> Since you need to respin this set anyway, I shall pick a nit:
> a trailing comma here would be preferable because then you
> don't need to change the line when you add the next entry
> to the enum.

yes. This is a good pratice. I will fix that in the next version.

Thanks for the review,

C.

> Otherwise
> Reviewed-by: Peter Maydell <address@hidden>
> 
> thanks
> -- PMM
>