[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 00/11] Provide a QOM-based authorization API
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v9 00/11] Provide a QOM-based authorization API |
Date: |
Mon, 15 Aug 2016 06:04:02 -0700 (PDT) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v9 00/11] Provide a QOM-based authorization API
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3a1d870 qmp: add support for mixed typed input visitor
01a6fe2 util: add QAuthZPAM object type for authorizing using PAM
b0380fb acl: delete existing ACL implementation
3de7df2 util: add QAuthZSimple object type for a simple access control list
6e54576 util: add QAuthZ object as an authorization base class
a128fba qom: support arbitrary non-scalar properties with -object
33a535d qapi: add a QmpInputVisitor that does string conversion
dcbcfba qapi: rename QmpOutputVisitor to QObjectOutputVisitor
2b2fc3a qapi: rename QmpInputVisitor to QObjectInputVisitor
f2552c3 option: make parse_option_bool/number non-static
4f7ac55 qdict: implement a qdict_crumple method for un-flattening a dict
=== OUTPUT BEGIN ===
Checking PATCH 1/11: qdict: implement a qdict_crumple method for un-flattening
a dict...
Checking PATCH 2/11: option: make parse_option_bool/number non-static...
Checking PATCH 3/11: qapi: rename QmpInputVisitor to QObjectInputVisitor...
ERROR: open brace '{' following struct go on the same line
#572: FILE: qapi/qobject-input-visitor.c:27:
+typedef struct StackObject
+{
ERROR: open brace '{' following struct go on the same line
#583: FILE: qapi/qobject-input-visitor.c:38:
+struct QObjectInputVisitor
+{
WARNING: line over 80 characters
#2480: FILE: tests/test-qobject-input-strict.c:94:
+ v = validate_test_init(data, "{ 'integer': -42, 'boolean': true, 'string':
'foo' }");
ERROR: line over 90 characters
#2508: FILE: tests/test-qobject-input-strict.c:122:
+ v = validate_test_init(data, "[ { 'string': 'string0', 'integer': 42 }, {
'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44 }
]");
ERROR: line over 90 characters
#2561: FILE: tests/test-qobject-input-strict.c:175:
+ v = validate_test_init(data, "{ 'integer': -42, 'boolean': true, 'string':
'foo', 'extra': 42 }");
ERROR: line over 90 characters
#2575: FILE: tests/test-qobject-input-strict.c:189:
+ v = validate_test_init(data, "{ 'string0': 'string0', 'dict1': {
'string1': 'string1', 'dict2': { 'userdef1': { 'integer': 42, 'string':
'string', 'extra': [42, 23, {'foo':'bar'}] }, 'string2': 'string2'}}}");
ERROR: line over 90 characters
#2589: FILE: tests/test-qobject-input-strict.c:203:
+ v = validate_test_init(data, "[ { 'string': 'string0', 'integer': 42 }, {
'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44,
'extra': 'ggg' } ]");
WARNING: line over 80 characters
#2618: FILE: tests/test-qobject-input-strict.c:232:
+ v = validate_test_init(data, "{ 'string': 'c', 'integer': 41, 'boolean':
true }");
ERROR: line over 90 characters
#2633: FILE: tests/test-qobject-input-strict.c:247:
+ v = validate_test_init(data, "{ 'integer': 42, 'string': 'c', 'string1':
'd', 'string2': 'e' }");
ERROR: line over 90 characters
#2677: FILE: tests/test-qobject-input-strict.c:291:
+ void (*test_func)(TestInputVisitorData *data,
const void *user_data))
ERROR: line over 90 characters
#2900: FILE: tests/test-qobject-input-visitor.c:173:
+ v = visitor_input_test_init(data, "{ 'integer': -42, 'boolean': true,
'string': 'foo' }");
ERROR: line over 90 characters
#2941: FILE: tests/test-qobject-input-visitor.c:214:
+ v = visitor_input_test_init(data, "[ { 'string': 'string0', 'integer': 42
}, { 'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44
} ]");
ERROR: line over 90 characters
#2981: FILE: tests/test-qobject-input-visitor.c:254:
+ v = visitor_input_test_init(data, "{ 'integer': -42, 'boolean': true,
'string': 'foo' }");
ERROR: line over 90 characters
#3478: FILE: tests/test-qobject-input-visitor.c:751:
+ void (*test_func)(TestInputVisitorData
*data, const void *user_data))
total: 12 errors, 2 warnings, 1864 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/11: qapi: rename QmpOutputVisitor to QObjectOutputVisitor...
ERROR: line over 90 characters
#2555: FILE: tests/test-qobject-output-visitor.c:792:
+ void (*test_func)(TestOutputVisitorData
*data, const void *user_data))
total: 1 errors, 0 warnings, 1384 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/11: qapi: add a QmpInputVisitor that does string conversion...
WARNING: line over 80 characters
#448: FILE: tests/test-qobject-input-visitor.c:420:
+ v = visitor_input_test_init_full(data, false, false, "{ 'a': null, 'b': ''
}");
total: 0 errors, 1 warnings, 423 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/11: qom: support arbitrary non-scalar properties with
-object...
Checking PATCH 7/11: util: add QAuthZ object as an authorization base class...
Checking PATCH 8/11: util: add QAuthZSimple object type for a simple access
control list...
Checking PATCH 9/11: acl: delete existing ACL implementation...
Checking PATCH 10/11: util: add QAuthZPAM object type for authorizing using
PAM...
Checking PATCH 11/11: qmp: add support for mixed typed input visitor...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v9 01/11] qdict: implement a qdict_crumple method for un-flattening a dict, (continued)
- [Qemu-devel] [PATCH v9 01/11] qdict: implement a qdict_crumple method for un-flattening a dict, Daniel P. Berrange, 2016/08/15
- [Qemu-devel] [PATCH v9 03/11] qapi: rename QmpInputVisitor to QObjectInputVisitor, Daniel P. Berrange, 2016/08/15
- [Qemu-devel] [PATCH v9 07/11] util: add QAuthZ object as an authorization base class, Daniel P. Berrange, 2016/08/15
- [Qemu-devel] [PATCH v9 04/11] qapi: rename QmpOutputVisitor to QObjectOutputVisitor, Daniel P. Berrange, 2016/08/15
- [Qemu-devel] [PATCH v9 05/11] qapi: add a QmpInputVisitor that does string conversion, Daniel P. Berrange, 2016/08/15
- [Qemu-devel] [PATCH v9 06/11] qom: support arbitrary non-scalar properties with -object, Daniel P. Berrange, 2016/08/15
- [Qemu-devel] [PATCH v9 08/11] util: add QAuthZSimple object type for a simple access control list, Daniel P. Berrange, 2016/08/15
- [Qemu-devel] [PATCH v9 09/11] acl: delete existing ACL implementation, Daniel P. Berrange, 2016/08/15
- [Qemu-devel] [PATCH v9 10/11] util: add QAuthZPAM object type for authorizing using PAM, Daniel P. Berrange, 2016/08/15
- [Qemu-devel] [PATCH v9 11/11] qmp: add support for mixed typed input visitor, Daniel P. Berrange, 2016/08/15
- Re: [Qemu-devel] [PATCH v9 00/11] Provide a QOM-based authorization API,
no-reply <=
- Re: [Qemu-devel] [PATCH v9 00/11] Provide a QOM-based authorization API, no-reply, 2016/08/15