Re: [Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

[Marek Vasut]

On 08/17/2016 10:26 PM, Peter Maydell wrote:
> On 17 August 2016 at 21:19, Marek Vasut <address@hidden> wrote:
>> On 08/16/2016 11:38 PM, Dmitry Osipenko wrote:
>>> If you would prefer to keep error'ing out, then I can suggest to add some
>>> verbose message instead of the assertion, like:
>>>
>>> if (!t->freq_hz) {
>>>     error_setg(errp, "altera_timer: \"clock-frequency\" property " \
> 
> You don't need the '\' at the end of the line here.
> 
>>>                      "must be provided");
>>>     return;
>>> }
>>
>> That's better, thanks.
>>
>> btw breaking strings is frowned upon in linux/u-boot as it makes it
>> impossible to git grep for error message. Does the same apply to qemu?
> 
> We tend to prefer to keep the lines below our line length limit,
> even if that means splitting them sometimes.

Is there any reason for that except for "we always did it that way" ?
Linux did it that way before, but then added this exception to make it
possible to grep for those strings.

Thanks

> thanks
> -- PMM
> 


-- 
Best regards,
Marek Vasut