Re: [Qemu-devel] [PATCH 0/4] lsi: misc fixes

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/4] lsi: misc fixes
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0734350 lsi: never set DMA FIFO Empty (DFE) bit in DSTAT register
f8e5db3 lsi: implement I/O memory space for Memory Move instructions
08becc1 lsi: do not exit QEMU if reading invalid register
17693be lsi: print register names in debug prints

=== OUTPUT BEGIN ===
Checking PATCH 1/4: lsi: print register names in debug prints...
ERROR: line over 90 characters
#31: FILE: hw/scsi/lsi53c895a.c:45:
+    "DSPS0", "DSPS1", "DSPS2", "DSPS3", "SCRATCHA0", "SCRATCHA1", "SCRATCHA2", 
"SCRATCHA3",

WARNING: line over 80 characters
#34: FILE: hw/scsi/lsi53c895a.c:48:
+    "STIME0", "STIME1", "RESPID", "0x4b", "STEST0", "STEST1", "STEST2", 
"STEST3",

WARNING: line over 80 characters
#36: FILE: hw/scsi/lsi53c895a.c:50:
+    "SBDL", "0x59", "0x5a", "0x5b", "SCRATCHB0", "SCRATCHB1", "SCRATCHB2", 
"SCRATCHB3",

ERROR: trailing statements should be on next line
#54: FILE: hw/scsi/lsi53c895a.c:1503:
+    case addr: ret = s->name & 0xff; break; \

ERROR: trailing statements should be on next line
#55: FILE: hw/scsi/lsi53c895a.c:1504:
+    case addr + 1: ret = (s->name >> 8) & 0xff; break; \

ERROR: trailing statements should be on next line
#56: FILE: hw/scsi/lsi53c895a.c:1505:
+    case addr + 2: ret = (s->name >> 16) & 0xff; break;

ERROR: trailing statements should be on next line
#63: FILE: hw/scsi/lsi53c895a.c:1508:
+    case addr: ret = s->name & 0xff; break; \

ERROR: trailing statements should be on next line
#64: FILE: hw/scsi/lsi53c895a.c:1509:
+    case addr + 1: ret = (s->name >> 8) & 0xff; break; \

ERROR: trailing statements should be on next line
#65: FILE: hw/scsi/lsi53c895a.c:1510:
+    case addr + 2: ret = (s->name >> 16) & 0xff; break; \

ERROR: trailing statements should be on next line
#66: FILE: hw/scsi/lsi53c895a.c:1511:
+    case addr + 3: ret = (s->name >> 24) & 0xff; break;

total: 8 errors, 2 warnings, 332 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/4: lsi: do not exit QEMU if reading invalid register...
Checking PATCH 3/4: lsi: implement I/O memory space for Memory Move 
instructions...
Checking PATCH 4/4: lsi: never set DMA FIFO Empty (DFE) bit in DSTAT register...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden