Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

[Dan Williams]

On Thu, Aug 18, 2016 at 8:46 PM, Xiao Guangrong
<address@hidden> wrote:
>
>
> On 08/19/2016 11:40 AM, Xiao Guangrong wrote:
>>
>>
>>
>> On 08/19/2016 02:54 AM, Vishal Verma wrote:
>>>
>>> On 08/18, Dan Williams wrote:
>>>>
>>>> [ adding Vishal who implemented the kernel side of nvdimm hotplug
>>>> support ]
>>>>
>>>> On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong
>>>> <address@hidden> wrote:
>>>>>
>>>>> This patchset is against commit c597dc90fbcd6 (virtio-net: allow
>>>>> increasing
>>>>> rx queue siz) on pci branch of Michael's git tree and can be found at:
>>>>>       https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2
>>>>>
>>>>> Changelog in v2:
>>>>>    Fixed signed integer overflow pointed out by Stefan Hajnoczi
>>>>>
>>>>> This patchset enables nvdimm hotplug support, it is used as pc-dimm
>>>>> hotplug,
>>>>> for example, a new nvdimm device can be plugged as follows:
>>>>> object_add
>>>>> memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3
>>>>> device_add nvdimm,id=nvdimm3,memdev=mem3
>>>>>
>>>>> and unplug it as follows:
>>>>> device_del nvdimm3
>>>>> object_del mem3
>>>>
>>>>
>>>> Did you test this against the Linux NFIT hotplug support?  We just
>>>> found that the Linux driver is not properly registering for ACPI0012
>>>> event notification.  Is a notification sent on a 'device_add' event?
>>>
>>>
>>> I've just sent out a patch that should fix this:
>>> https://lists.01.org/pipermail/linux-nvdimm/2016-August/006637.html
>>>
>>
>> Interesting. I am using the kvm tree, queue branch, the top commit is
>> 8ff7b956471f:
>>   Merge tag 'kvm-s390-next-4.8-2' of
>> git://git.kernel.org/pub/scm/linux/kernel
>>
>> It works.
>
>
> It triggers 'notify' event, not 'device add'.

Ah, I missed that the notification handler gets registered via
acpi_device_install_notify_handler() so this
ACPI_DRIVER_ALL_NOTIFY_EVENTS is not needed.

Thank you for confirming.