[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36 |
Date: |
Mon, 29 Aug 2016 10:25:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 29/08/2016 09:52, address@hidden wrote:
> From: ronyweng <address@hidden>
>
> Openstack Cinder assigns volume a 36 characters uuid as serial.
> Qemu will shrinks the uuid to 20 characters,
> missmatch with original uuid.
>
> Signed-off-by: Rony Weng <address@hidden>
> ---
> hw/scsi/scsi-disk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 836a155..0e1bb68 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -599,8 +599,8 @@ static int scsi_disk_emulate_inquiry(SCSIRequest *req,
> uint8_t *outbuf)
> }
>
> l = strlen(s->serial);
> - if (l > 20) {
> - l = 20;
> + if (l > 36) {
> + l = 36;
> }
>
> DPRINTF("Inquiry EVPD[Serial number] "
>
Cc: address@hidden
Thanks, queued for 2.8 and 2.7.1
Paolo