Re: [Qemu-devel] [Qemu-stable] [PATCH v2 for 2.7] ui: fix refresh of VNC server surface

[Peter Maydell]

On 29 August 2016 at 14:44, Peter Lieven <address@hidden> wrote:
> Am 16.08.2016 um 18:30 schrieb Daniel P. Berrange:

>> To fix this we must explicitly mark the entire guest desktop
>> as dirty after re-creating the server surface. Move this
>> logic into vnc_update_server_surface() so it is guaranteed
>> to be call in all code paths that re-create the surface
>> instead of only in vnc_dpy_switch()
>>
>> Signed-off-by: Daniel P. Berrange <address@hidden>

> I can confirm this issue now. Its only visible if the VNC client does not
> send a SET_PIXEL_FORMAT message.
> Which my client does and this masked the issue for me. The set pixel format
> routine invalidates
> the whole display which results in a vnc_dpy_switch which masks the guest fb
> dirty. Why this invalidation
> takes place I do not understand, but this can be sorted out lated.
>
> For this patch:
> Tested-by: Peter Lieven <address@hidden>
> Reviewed-by: Peter Lieven <address@hidden>

Applied to master for 2.7, thanks.

-- PMM