Re: [Qemu-devel] [PATCH for 2.8 06/11] intel_iommu: support device iotlb descriptor

[Peter Xu]

On Wed, Aug 31, 2016 at 10:54:36AM +0800, Jason Wang wrote:
> >>  static void x86_iommu_instance_init(Object *o)
> >>  {
> >>      X86IOMMUState *s = X86_IOMMU_DEVICE(o);
> >>@@ -108,6 +120,11 @@ static void x86_iommu_instance_init(Object *o)
> >>      s->intr_supported = false;
> >>      object_property_add_bool(o, "intremap", x86_iommu_intremap_prop_get,
> >>                               x86_iommu_intremap_prop_set, NULL);
> >>+    s->dt_supported = false;
> >>+    object_property_add_bool(o, "device_iotlb",
> >>+                             x86_iommu_device_iotlb_prop_get,
> >>+                             x86_iommu_device_iotlb_prop_set,
> >>+                             NULL);
> >Nit 1: use "device-iotlb" instead of "device_iotlb"?
> 
> Yes.
> 
> >Nit 2: use Property bit (like vtd_properties)?
> 
> Not sure, I thought this may be reused by AMD IOMMU but maybe I was wrong.

I mean to create another Property for x86-iommus. :)

Anyway both work for me, and actually "intremap" property is doing it
that way as well...

-- peterx