Re: [Qemu-devel] [PATCH] spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call

[Laurent Vivier]

On 02/09/2016 10:02, Thomas Huth wrote:
> On 01.09.2016 18:34, Laurent Vivier wrote:
>>
>>
>> On 01/09/2016 15:13, Thomas Huth wrote:
...
>>> Patch looks basically fine to me. One more thought though:
>>> What about migration? Don't we need to migrate the perm_mac array, too,
>>> or is this already covered by the dev->nicconf.macaddr array?
>>
>> We don't need to migrate perm_mac because it is initialized from the
>> command line (it is only used to reset the card) on the destination side
>> as it is on the source side.
>>
>> I've tested migration and all seems to work fine, but if you want to
>> double-check don't hesitate :)
> 
> My concern was that the MAC address on the command line on the
> destination side is rather set to the old, original MAC address by the
> management tools (libvirt), 

Right

> so that you suddenly end up with the
> previous MAC address again after migration.

No, the dynamically set mac address is migrated, the one from the
command line is only used if a reset occurs.

Thanks,
Laurent