[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] trace: Allow events without arguments
|
From: |
Lluís Vilanova |
|
Subject: |
Re: [Qemu-devel] [PATCH] trace: Allow events without arguments |
|
Date: |
Tue, 06 Sep 2016 10:47:33 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Stefan Hajnoczi writes:
> On Fri, Aug 26, 2016 at 11:12:47AM +0200, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>> scripts/tracetool/__init__.py | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
>> index be24039..96657e6 100644
>> --- a/scripts/tracetool/__init__.py
>> +++ b/scripts/tracetool/__init__.py
>> @@ -72,6 +72,11 @@ class Arguments:
>> arg_str : str
>> String describing the event arguments.
>> """
>> + # check for empty argument list
>> + arg_str = arg_str.strip()
>> + if arg_str == "":
>> + return Arguments([])
>> +
> Why is this necessary? C syntax uses f(void) and not f().
> We already have trace events with no argument. They use the correct C
> syntax.
Sorry, I wasn't aware of that. My bad.
Thanks,
Lluis