[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] crypto: misc tweaks & improvements to pbkdf
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] crypto: misc tweaks & improvements to pbkdf code |
Date: |
Thu, 8 Sep 2016 12:48:56 -0700 (PDT) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/6] crypto: misc tweaks & improvements to pbkdf
code
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
15cfa9d crypto: support more hash algorithms for pbkdf
eb171ab crypto: increase default pbkdf2 time for luks to 2 seconds
b16d6e2 crypto: remove bogus /= 2 for pbkdf iterations
b48082f crypto: use correct derived key size when timing pbkdf
a61fe5a crypto: clear out buffer after timing pbkdf algorithm
cce4ddf crypto: make PBKDF iterations configurable for LUKS format
=== OUTPUT BEGIN ===
Checking PATCH 1/6: crypto: make PBKDF iterations configurable for LUKS
format...
Checking PATCH 2/6: crypto: clear out buffer after timing pbkdf algorithm...
Checking PATCH 3/6: crypto: use correct derived key size when timing pbkdf...
Checking PATCH 4/6: crypto: remove bogus /= 2 for pbkdf iterations...
Checking PATCH 5/6: crypto: increase default pbkdf2 time for luks to 2
seconds...
Checking PATCH 6/6: crypto: support more hash algorithms for pbkdf...
ERROR: if this code is redundant consider removing it
#211: FILE: tests/test-crypto-pbkdf.c:332:
+#if 0
total: 1 errors, 0 warnings, 185 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [PATCH 1/6] crypto: make PBKDF iterations configurable for LUKS format, (continued)