[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers
From: |
Leon Alrae |
Subject: |
Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers |
Date: |
Mon, 12 Sep 2016 08:59:33 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Sep 09, 2016 at 09:26:29AM -0700, Richard Henderson wrote:
> On 09/09/2016 07:46 AM, Leon Alrae wrote:
> >Wouldn't it be useful if tcg.h provided also aliases for _le/_be atomic
> >helpers (equivalent to helper_ret_X_mmu) so that in target-* code we wouldn't
> >need to care about the endianness (specifically I'm thinking about SC in MIPS
> >where I need to select between helper_atomic_cmpxchgl_le_mmu() and
> >helper_atomic_cmpxchgl_be_mmu()).
>
> Perhaps. I would have hoped that you could do the SC inline now
> though, and tcg_gen_atomic_cmpxchg() will do the selection for you.
On every SC we need to do the virtual -> physical address translation as we
have to compare the physical address against that of the preceeding LL.
This operation seems too complex to be inlined :(
Leon
- [Qemu-devel] [PATCH v3 16/34] target-i386: emulate LOCK'ed cmpxchg using cmpxchg helpers, (continued)
- [Qemu-devel] [PATCH v3 16/34] target-i386: emulate LOCK'ed cmpxchg using cmpxchg helpers, Richard Henderson, 2016/09/03
- [Qemu-devel] [PATCH v3 14/34] tcg: Add atomic128 helpers, Richard Henderson, 2016/09/03
- [Qemu-devel] [PATCH v3 18/34] target-i386: emulate LOCK'ed INC using atomic helper, Richard Henderson, 2016/09/03
- [Qemu-devel] [PATCH v3 17/34] target-i386: emulate LOCK'ed OP instructions using atomic helpers, Richard Henderson, 2016/09/03
- [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers, Richard Henderson, 2016/09/03
Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers, Alex Bennée, 2016/09/12
Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers, Alex Bennée, 2016/09/13
[Qemu-devel] [PATCH v3 19/34] target-i386: emulate LOCK'ed NOT using atomic helper, Richard Henderson, 2016/09/03
[Qemu-devel] [PATCH v3 15/34] tcg: Add CONFIG_ATOMIC64, Richard Henderson, 2016/09/03