[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: hmp_host_net_remove: Del the -net option o
|
From: |
Shmulik Ladkani |
|
Subject: |
Re: [Qemu-devel] [PATCH] net: hmp_host_net_remove: Del the -net option of the removed host_net |
|
Date: |
Mon, 12 Sep 2016 21:49:37 +0300 |
On Mon, 5 Sep 2016 12:11:02 +0300 Shmulik Ladkani <address@hidden> wrote:
> Upon hmp_host_net_remove(), the appropriate -net client is deleted
> (according to the given vlan_id and device id), as well as the
> corresponsing hub port.
>
> However, the relevant '-net' option that was added by former
> hmp_host_net_add() call is still present in "net" options group.
>
> This makes the following legit HMP sequence erroneous:
>
> (qemu) host_net_add tap id=n1,ifname=tap1,script=no,downscript=no,vlan=1
> (qemu) host_net_remove 1 n1
> (qemu) host_net_add tap id=n1,ifname=tap1,script=no,downscript=no,vlan=1
> Duplicate ID 'n1' for net
>
> Fix, by deleting the stored '-net' option associated with the given
> device id.
>
> Signed-off-by: Shmulik Ladkani <address@hidden>
ping?