Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

[Marcel Apfelbaum]

On 09/14/2016 01:01 PM, Igor Mammedov wrote:
> commit (a4d3c834 pc: Add 2.8 machine) didn't ammend
> PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in
>
>     {\
>         .driver   = "virtio-pci",\
>         .property = "page-per-vq",\
>         .value    = "on",\
>     },
>
> and
>
>     {\
>         .driver   = TYPE_X86_CPU,\
>         .property = "l3-cache",\
>         .value    = "off",\
>     },
>
> being ignored and as result change PC_COMPAT_2_6 behaviour.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  include/hw/i386/pc.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index ebba151..d5654ab 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -381,6 +381,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
>      HW_COMPAT_2_7
>
>  #define PC_COMPAT_2_6 \
> +    PC_COMPAT_2_7 \
>      HW_COMPAT_2_6 \
>      {\
>          .driver   = "fw_cfg_io",\

Reviewed-by: Marcel Apfelbaum <address@hidden>

Thanks,
Marcel