[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge
Date: Wed, 14 Sep 2016 08:54:16 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 09/13/2016 11:23 PM, Alexey Kardashevskiy wrote:

>>> Also, we don't have to abbreviate; 'bridge-name' may be easier to
>>> understand than 'br', as well as a mention of the default value if the
>>> parameter is not supplied.
> The existing NetdevBridgeOptions does not do this in json as well and it
> does in qemu-options.hx, so does my patch. Do I have to fix a bridge first
> before reposting this patch?...

If that interface is already baked in as 'br', then leave it alone.

> When exactly is the content of qapi-schema.json's comments shown to a user?

Not yet, but Marc-Andre has patches pending that merge qemu-options.hx
and qemu-schema.json so that we have a single file with documentation,
rather than two semi-inconsistent copies.

>> FWIW @br is consistent with what we already have in NetdevBridgeOptions
>> since 1.2.
> Right, this is why "br=".

Okay, the argument of consistency with pre-existing interfaces is

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]