[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] block: Accept device model name for x-blo
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] block: Accept device model name for x-blockdev-insert-medium |
Date: |
Thu, 15 Sep 2016 10:37:16 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 14.09.2016 um 22:57 hat Eric Blake geschrieben:
> On 08/19/2016 11:50 AM, Kevin Wolf wrote:
> > In order to remove the necessity to use BlockBackend names in the
> > external API, we want to allow qdev device names in all device related
> > commands.
> >
> > This converts x-blockdev-insert-medium to accept a qdev device name.
>
> Since this command is experimental...
>
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
>
> > +++ b/qapi/block-core.json
> > @@ -2380,14 +2380,17 @@
> > # This command is still a work in progress and is considered experimental.
> > # Stay away from it unless you want to help with its development.
> > #
> > -# @device: block device name
> > +# @device: block device name (deprecated, use @id instead)
> > +#
> > +# @id: the name or QOM path of the guest device (since: 2.8)
>
> ...why even bother to deprecate 'device'? Can't we just do a whole-sale
> switch to a required 'id' only? Or should such a wholesale switch be
> reserved for the day that we remove the x- prefix when promoting the
> command to stable?
I tried this for the experimental commands, but I think it required some
more test case rewrites, so I decided to leave it for later. Not
necessarily "when promoting to stable" later, but a separate series
anyway.
Kevin
pgpLHcgGqBckZ.pgp
Description: PGP signature