[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/10] replay: save/load initial state
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/10] replay: save/load initial state |
Date: |
Thu, 15 Sep 2016 11:25:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 15/09/2016 11:01, Pavel Dovgalyuk wrote:
> +{
> + if (replay_mode == REPLAY_MODE_RECORD) {
> + QDict *opts = qdict_new();
> + qdict_put(opts, "name", qstring_from_str("replay_init"));
> + hmp_savevm(cur_mon, opts);
> + QDECREF(opts);
> + } else if (replay_mode == REPLAY_MODE_PLAY) {
> + load_vmstate("replay_init");
See my other message about a suggestion to remove the hardcoded snapshot
name.
Also, I think the return value of load_vmstate and hmp_savevm should be
checked.
> + }
> +}
> diff --git a/vl.c b/vl.c
> index 1c68779..6698d88 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4593,6 +4593,8 @@ int main(int argc, char **argv, char **envp)
> if (load_vmstate(loadvm) < 0) {
> autostart = 0;
> }
> + } else {
> + replay_vmstate_init();
> }
Should -loadvm be incompatible with -rr?
Paolo
[Qemu-devel] [PATCH v2 04/10] replay: save/load initial state, Pavel Dovgalyuk, 2016/09/15
- Re: [Qemu-devel] [PATCH v2 04/10] replay: save/load initial state,
Paolo Bonzini <=
[Qemu-devel] [PATCH v2 05/10] replay: move internal data to the structure, Pavel Dovgalyuk, 2016/09/15
[Qemu-devel] [PATCH v2 06/10] replay: vmstate for replay module, Pavel Dovgalyuk, 2016/09/15
[Qemu-devel] [PATCH v2 07/10] replay: allow replay stopping and restarting, Pavel Dovgalyuk, 2016/09/15