Re: [Qemu-devel] [PATCH v5] fpu: add mechanism to check for invalid long double formats

[Peter Maydell]

On 18 August 2016 at 16:35, Peter Maydell <address@hidden> wrote:
> On 17 August 2016 at 01:14, Andrew Dutcher <address@hidden> wrote:
>> All operations that take a floatx80 as an operand need to have their
>> inputs checked for malformed encodings. In all of these cases, use the
>> function floatx80_invalid_encoding to perform the check. If an invalid
>> operand is found, raise an invalid operation exception, and then return
>> either NaN (for fp-typed results) or the integer indefinite value (the
>> minimum representable signed integer value, for int-typed results).
>>
>> For the non-quiet comparison operations, this touches adjacent code in
>> order to pass style checks.
>>
>> Signed-off-by: Andrew Dutcher <address@hidden>
>
> This version looks good -- thanks for your effort in working
> through the code review process.
>
> Reviewed-by: Peter Maydell <address@hidden>
>
> and I'll make sure it gets committed once the trunk reopens
> after the 2.7 release.

Now applied to master, thanks.

I had to change a couple of "1 << 63" to "1ULL << 63" to fix some
compile failures.

-- PMM