Re: [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages

[Paolo Bonzini]

On 15/09/2016 17:07, Dr. David Alan Gilbert wrote:
> * Paolo Bonzini (address@hidden) wrote:
>> /me hides in the corner...
>>
>> Cc: Dave Gilbert <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>  hw/i386/kvm/apic.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
>> index 5d140b9..feb0002 100644
>> --- a/hw/i386/kvm/apic.c
>> +++ b/hw/i386/kvm/apic.c
>> @@ -141,7 +141,6 @@ static void kvm_apic_put(void *data)
>>  
>>  static void kvm_apic_post_load(APICCommonState *s)
>>  {
>> -    fprintf(stderr, "%s: Yeh\n", __func__);
>>      run_on_cpu(CPU(s->cpu), kvm_apic_put, s);
>>  }
> 
> Hmm, I think you picked up the debug version we exchanged
> privately rather than the one I actually posted which
> I'd excised the debug from:
>    https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02658.html
> 
> I think the only other change was that the one I posted I'd
> reformatted kvm_put_apic_state so it wasn't 81 characters long.

Yes, I did.  It's me who hides in the corner, not you. :)

Paolo

> 
> Dave
> 
>>  
>> -- 
>> 1.8.3.1
>>
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
>