Re: [Qemu-devel] [PATCH RFC v1 10/29] target-arc: POP, PUSH

[Richard Henderson]

On 09/08/2016 03:31 PM, Michael Rolnik wrote:
> +    tcg_gen_subi_tl(cpu_sp, cpu_sp, 4);
> +    tcg_gen_qemu_st_tl(src1, cpu_sp, ctx->memidx, MO_UL);

You need to delay the write to the stack pointer until after the store, 
otherwise sp will have the incorrect contents if the page is not writable.


r~