|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH RFC v1 10/29] target-arc: POP, PUSH |
Date: | Tue, 20 Sep 2016 16:57:51 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/08/2016 03:31 PM, Michael Rolnik wrote:
+ tcg_gen_subi_tl(cpu_sp, cpu_sp, 4); + tcg_gen_qemu_st_tl(src1, cpu_sp, ctx->memidx, MO_UL);
You need to delay the write to the stack pointer until after the store, otherwise sp will have the incorrect contents if the page is not writable.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |