[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] docker: Print used options before doing con
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 6/9] docker: Print used options before doing configure |
Date: |
Wed, 21 Sep 2016 09:41:26 +0100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, Sep 21, 2016 at 11:49:25AM +0800, Fam Zheng wrote:
> This makes the configure command more obvious which usually has useful
> information.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/docker/common.rc | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 0c6d8d5..510a3ad 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -23,11 +23,13 @@ requires()
>
> build_qemu()
> {
> - $QEMU_SRC/configure \
> - --enable-werror \
> - ${TARGET_LIST:+"--target-list=${TARGET_LIST}"} \
> - --prefix="$PWD/install" \
> - $EXTRA_CONFIGURE_OPTS \
> - "$@"
> + config_opts="--enable-werror \
> + ${TARGET_LIST:+--target-list=${TARGET_LIST}} \
> + --prefix=$PWD/install \
> + $EXTRA_CONFIGURE_OPTS \
> + $@"
> + echo "Configure options:"
> + echo $config_opts
> + $QEMU_SRC/configure $config_opts
> make $MAKEFLAGS
> }
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-devel] [PATCH 1/9] docker: Generate /packages.txt in centos6 image, (continued)
- [Qemu-devel] [PATCH 2/9] docker: Generate /packages.txt in fedora image, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 3/9] docker: Generate /packages.txt in ubuntu image, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 4/9] docker: Update fedora image to latest, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 5/9] docker: Flatten default target list in test-quick, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 6/9] docker: Print used options before doing configure, Fam Zheng, 2016/09/20
- Re: [Qemu-devel] [PATCH 6/9] docker: Print used options before doing configure,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH 7/9] docker: Support showing environment information, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 8/9] docker: Terminate instances at SIGTERM and SIGHUP, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 9/9] docker: exec $CMD, Fam Zheng, 2016/09/20