Re: [Qemu-devel] [PATCH] crypto: add CTR mode support

[Daniel P. Berrange]

On Thu, Sep 22, 2016 at 12:17:43AM -0700, address@hidden wrote:
> Hi,
> 
> Your series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce 
> it
> locally.

> GTESTER tests/test-crypto-cipher
> **
> ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher: 
> assertion failed: (err == NULL)
> GTESTER tests/test-crypto-secret
> GTESTER tests/test-qga
> GTESTER tests/test-timed-average
> GTESTER tests/test-io-task
> GTester: last random seed: R02S94c4e01f686829a0cec78fda5b9551b8
> **
> ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher: 
> assertion failed: (err == NULL)
> GTESTER tests/test-io-channel-socket
> GTester: last random seed: R02S2749a35e038d902a633846f61116c95d
> GTESTER tests/test-io-channel-file
> **
> ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher: 
> assertion failed: (err == NULL)

It seems you exposed a pre-existing bug in the test suite. It is using
qcrypto_cipher_supports() to check if the cipher algorithm is supported
before running each test case. Unfortunately this assumes that if the
algorithm is supported, then all cipher modes are also supported, which
is not true with --disable-gcrypt --disable-nettle configure flags.

So we need to extend qcrypto_cipher_supports() to take both the algorithm
and mode as parameters.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|