qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/9] tcg/optimize: move default return out of


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 2/9] tcg/optimize: move default return out of if statement
Date: Thu, 22 Sep 2016 08:35:24 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 09/22/2016 03:13 AM, Alex Bennée wrote:
This is to appease sanitizer builds which complain that:

  "error: control reaches end of non-void function"

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
 tcg/optimize.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index 9998ac7..0f13490 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -468,9 +468,8 @@ static TCGArg do_constant_folding_cond(TCGOpcode op, TCGArg 
x,
         default:
             return 2;
         }
-    } else {
-        return 2;
     }
+    return 2;

I'm disappointed that the sanitizer doesn't see the abort above as a noreturn. That said, this isn't wrong so,

Reviewed-by: Richard Henderson <address@hidden>


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]