[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID proper
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit |
Date: |
Mon, 26 Sep 2016 13:10:08 +0200 |
On Thu, 22 Sep 2016 18:16:47 +0200
Paolo Bonzini <address@hidden> wrote:
> On 22/09/2016 18:00, Igor Mammedov wrote:
> > > Why not just return initial_apic_id? This is the meaning the property
> > > had before your patch.
> >
> > initial_apic_id is immutable but 'id' could be changed at runtime by guest
> > in xAPIC mode
> > so returned value depends on xAPIC/x2APIC mode
>
> Understood, but this is just a possibly poorly-named property. "id"
> (e.g. from info qtree as opposed to info lapic) used to be the initial
> APIC ID always, even in x2APIC mode.
'info qtree' doesn't show CPUs anymore (since ICC bus has been removed),
but if it were it would show effective APIC ID. Same applie[ds] for
reading property value with qom-get.
>
> Not a big deal, but thought I'd mention it since you can keep using
> static properties.
PS:
changing initial APIC ID from guest probably wouldn't work anyway
and beak somewhere else, so we could just continue to ignore
it and use static properties for now if you prefer.
>
> Paolo
>
> > so I'm just following spec here.
- [Qemu-devel] [PATCH v2 03/14] pc: acpi: x2APIC support for SRAT table, (continued)
- [Qemu-devel] [PATCH v2 03/14] pc: acpi: x2APIC support for SRAT table, Igor Mammedov, 2016/09/22
- [Qemu-devel] [PATCH v2 04/14] acpi: cphp: support x2APIC entry in cpu._MAT, Igor Mammedov, 2016/09/22
- [Qemu-devel] [PATCH v2 01/14] numa: reduce code duplication by adding helper numa_get_node_for_cpu(), Igor Mammedov, 2016/09/22
- [Qemu-devel] [PATCH v2 05/14] acpi: cphp: force switch to modern cpu hotplug if APIC ID > 254, Igor Mammedov, 2016/09/22
- [Qemu-devel] [PATCH v2 06/14] pc: leave max apic_id_limit only in legacy cpu hotplug code, Igor Mammedov, 2016/09/22
- [Qemu-devel] [PATCH v2 08/14] pc: apic_common: restore APIC ID to initial ID on reset, Igor Mammedov, 2016/09/22
- [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit, Igor Mammedov, 2016/09/22
[Qemu-devel] [PATCH v2 09/14] pc: apic_common: reset APIC ID to initial ID when switching into x2APIC mode, Igor Mammedov, 2016/09/22
[Qemu-devel] [PATCH v2 10/14] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode, Igor Mammedov, 2016/09/22
[Qemu-devel] [PATCH v2 12/14] increase MAX_CPUMASK_BITS from 255 to 288, Igor Mammedov, 2016/09/22
[Qemu-devel] [PATCH v2 11/14] pc: clarify FW_CFG_MAX_CPUS usage comment, Igor Mammedov, 2016/09/22
[Qemu-devel] [PATCH v2 13/14] pc: add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs, Igor Mammedov, 2016/09/22