[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/4] ui/vnc-enc-tight: remove switch and have single
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 4/4] ui/vnc-enc-tight: remove switch and have single return |
Date: |
Wed, 28 Sep 2016 14:01:57 +0200 |
From: Alex Bennée <address@hidden>
When enabling the sanitizer build it will complain about control
reaching a non-void function. Normally the compiler should detect that
there is only one possible exit given a static VNC_SERVER_FB_BYTES.
As we always expect a static VNC_SERVER_FB_BYTES I've added a compile
time assert and just called the sub-function directly.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc-enc-tight.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 49df85e..1e53b1c 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -707,10 +707,8 @@ check_solid_tile32(VncState *vs, int x, int y, int w, int
h,
static bool check_solid_tile(VncState *vs, int x, int y, int w, int h,
uint32_t* color, bool samecolor)
{
- switch (VNC_SERVER_FB_BYTES) {
- case 4:
- return check_solid_tile32(vs, x, y, w, h, color, samecolor);
- }
+ QEMU_BUILD_BUG_ON(VNC_SERVER_FB_BYTES != 4);
+ return check_solid_tile32(vs, x, y, w, h, color, samecolor);
}
static void find_best_solid_area(VncState *vs, int x, int y, int w, int h,
--
1.8.3.1
- [Qemu-devel] [PULL 0/4] ui: console+vnc fixes, switch spice to pure opengl with gl=on., Gerd Hoffmann, 2016/09/28
- [Qemu-devel] [PULL 1/4] console: skip same-size resize, Gerd Hoffmann, 2016/09/28
- [Qemu-devel] [PULL 3/4] spice/gl: render DisplaySurface via opengl, Gerd Hoffmann, 2016/09/28
- [Qemu-devel] [PULL 2/4] console: track gl_block state in QemuConsole, Gerd Hoffmann, 2016/09/28
- [Qemu-devel] [PULL 4/4] ui/vnc-enc-tight: remove switch and have single return,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PULL 0/4] ui: console+vnc fixes, switch spice to pure opengl with gl=on., Peter Maydell, 2016/09/28