[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] blockdev-mirror: Sanity check before mov
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] blockdev-mirror: Sanity check before moving target_bs AioContext |
Date: |
Thu, 29 Sep 2016 11:14:44 +0800 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, 09/28 18:37, Max Reitz wrote:
> On 27.09.2016 08:37, Fam Zheng wrote:
> > Similar to blockdev-backup, if the target was already moved to a
> > different AioContext, bad things can happen. This happens when the
> > target belongs to a data plane device. It's a very unlikely case, but
> > let's check it anyway.
>
> You didn't implement it for blockdev-mirror, though, but for
> drive-mirror (which I don't think needs this check).
Ugh, will fix.
- [Qemu-devel] [PATCH v2 0/5] block: keep AioContext pointer in BlockBackend, Fam Zheng, 2016/09/27
- [Qemu-devel] [PATCH v2 1/5] blockdev-mirror: Sanity check before moving target_bs AioContext, Fam Zheng, 2016/09/27
- [Qemu-devel] [PATCH v2 2/5] blockdev: Move BDS AioContext before inserting to BB, Fam Zheng, 2016/09/27
- [Qemu-devel] [PATCH v2 4/5] migration: Set correct AioContext to BlockBackend, Fam Zheng, 2016/09/27
- [Qemu-devel] [PATCH v2 3/5] block: Introduce and make use of blk_new_with_root, Fam Zheng, 2016/09/27
- [Qemu-devel] [PATCH v2 5/5] block: keep AioContext pointer in BlockBackend, Fam Zheng, 2016/09/27