[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/9] ui: refactor method for setting up VncDispl
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/9] ui: refactor method for setting up VncDisplay auth types |
Date: |
Thu, 29 Sep 2016 11:10:30 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/29/2016 10:45 AM, Daniel P. Berrange wrote:
> There is alot of repeated code in the auth type setup method,
s/alot/a lot/
> particularly around checking TLS credential types. Refactor
> it to reduce duplication and instead of having one method
> do both plain and websockets at once, call it separately
> for each.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> ui/vnc.c | 124
> +++++++++++++++++++++++++++------------------------------------
> ui/vnc.h | 1 +
> 2 files changed, 53 insertions(+), 72 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/9] Misc VNC server code cleanups, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 1/9] ui: remove misleading comment from vnc_init_state, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 2/9] ui: remove 'enabled' and 'ws_enabled' fields from VncState, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 3/9] ui: remove 'ws_tls' field from VncState, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 5/9] ui: refactor method for setting up VncDisplay auth types, Daniel P. Berrange, 2016/09/29
- Re: [Qemu-devel] [PATCH 5/9] ui: refactor method for setting up VncDisplay auth types,
Eric Blake <=
- [Qemu-devel] [PATCH 4/9] ui: rename misleading 'VncDisplay' variables, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 7/9] ui: remove bogus call to reset_keys() in vnc_init_state, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 8/9] ui: move some initialization out of vnc_init_state, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 6/9] ui: remove bogus call to graphic_hw_update() in vnc_listen_io, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 9/9] ui: rename vnc_init_state to vnc_start_protocol, Daniel P. Berrange, 2016/09/29