[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-s
From: |
Hailiang Zhang |
Subject: |
Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT) |
Date: |
Fri, 30 Sep 2016 14:27:26 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 2016/9/30 13:53, Amit Shah wrote:
On (Thu) 29 Sep 2016 [16:46:20], zhanghailiang wrote:
This is the 20th version of COLO frame series.
COLO Block replication and proxy (COLO compare) series are both been
merged into upstream already. And further works can be done now to
realize the full COLO feature.
Athough there are still no feedbacks from community for this part,
But I would like to rebase this series to the recent upstream.
Hi Amit,
Thanks for your prompt reply :)
Thanks - I see most of the patches are reviewed by at least Dave, with
a couple reviewed by Eric as well.
I know Juan is compiling a pull req, and he'll reach out if there are
concerns.
Great.
In the meanwhile, can you check why the autobuilder fails to compile
with your patchset?
Yes, It was related to the 9th patch, where i used %lu to print value of
'uint64_t' type
which is incorrect. I think it can be fixed by use 'PRIu64' to print uint64_t
value.
The wrong codes are:
+ if (total_size != value) {
+ error_report("Got %lu VMState data, less than expected %lu",
+ total_size, value);
+ goto out;
+ }
Fixed:
+ if (total_size != value) {
+ error_report("Got%" PRIu64 " VMState data, less than expected %"
PRIu64,
+ total_size, value);
+ goto out;
+ }
Should i resend this series with this be fixed now ?
Thanks.
hailiang
Thanks,
Amit
.
- [Qemu-devel] [PATCH COLO-Frame (Base) v20 01/17] migration: Introduce capability 'x-colo' to migration, (continued)
- [Qemu-devel] [PATCH COLO-Frame (Base) v20 01/17] migration: Introduce capability 'x-colo' to migration, zhanghailiang, 2016/09/29
- [Qemu-devel] [PATCH COLO-Frame (Base) v20 12/17] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover, zhanghailiang, 2016/09/29
- [Qemu-devel] [PATCH COLO-Frame (Base) v20 13/17] COLO: Introduce state to record failover process, zhanghailiang, 2016/09/29
- [Qemu-devel] [PATCH COLO-Frame (Base) v20 06/17] COLO: Introduce checkpointing protocol, zhanghailiang, 2016/09/29
- [Qemu-devel] [PATCH COLO-Frame (Base) v20 09/17] COLO: Load VMState into QIOChannelBuffer before restore it, zhanghailiang, 2016/09/29
- [Qemu-devel] [PATCH COLO-Frame (Base) v20 02/17] COLO: migrate COLO related info to secondary node, zhanghailiang, 2016/09/29
- [Qemu-devel] [PATCH COLO-Frame (Base) v20 10/17] COLO: Add checkpoint-delay parameter for migrate-set-parameters, zhanghailiang, 2016/09/29
- [Qemu-devel] [PATCH COLO-Frame (Base) v20 14/17] COLO: Implement the process of failover for primary VM, zhanghailiang, 2016/09/29
- Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT), no-reply, 2016/09/29
- Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT), Amit Shah, 2016/09/30
- Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT),
Hailiang Zhang <=