[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/1] target-arm: A64: Fix decoding of iss_sf
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/1] target-arm: A64: Fix decoding of iss_sf in disas_ld_lit |
Date: |
Fri, 30 Sep 2016 13:36:59 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/30/2016 12:34 PM, Peter Maydell wrote:
>>>> + bool iss_sf = opc == 0 ? false : true;
Feels like a double negative.
>>>
>>> You could simplify that to:
>>>
>>> bool iss_sf = !(opc == 0);
>>
>> I don't really see how that is simpler/clearer.
>>
>> I considered:
>> bool iss_sf = opc != 0;
Or even shorter:
bool iss_sf = !opc;
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature