Re: [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu

[Paolo Bonzini]

On 10/10/2016 17:46, Alex Bennée wrote:
> The changes to run_on_cpu and friends mean that all helpers are passed
> the CPUState of vCPU they are running on. The conversion missed the
> field in commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 which
> introduced bugs.
> 
> Reported-by: Claudio Imbrenda <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  kvm-all.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index efb5fe3..3dcce16 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -2215,15 +2215,14 @@ int kvm_sw_breakpoints_active(CPUState *cpu)
>  
>  struct kvm_set_guest_debug_data {
>      struct kvm_guest_debug dbg;
> -    CPUState *cpu;
>      int err;
>  };
>  
> -static void kvm_invoke_set_guest_debug(CPUState *unused_cpu, void *data)
> +static void kvm_invoke_set_guest_debug(CPUState *cpu, void *data)
>  {
>      struct kvm_set_guest_debug_data *dbg_data = data;
>  
> -    dbg_data->err = kvm_vcpu_ioctl(dbg_data->cpu, KVM_SET_GUEST_DEBUG,
> +    dbg_data->err = kvm_vcpu_ioctl(cpu, KVM_SET_GUEST_DEBUG,
>                                     &dbg_data->dbg);
>  }
>  
> 

Queued, thanks - or if Christian wants to send a pull request himself,
he can go ahead.

Paolo