qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/4] tests/docker: test-build script


From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH v2 2/4] tests/docker: test-build script
Date: Tue, 11 Oct 2016 09:49:58 +0100
User-agent: mu4e 0.9.17; emacs 25.1.50.3

Fam Zheng <address@hidden> writes:

> On Mon, 10/03 17:32, Alex Bennée wrote:
>> Much like test-quick but only builds. This is useful for some of the
>> build targets like ThreadSanitizer that don't yet pass "make check".
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>>  tests/docker/test-build | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>  create mode 100755 tests/docker/test-build
>>
>> diff --git a/tests/docker/test-build b/tests/docker/test-build
>> new file mode 100755
>> index 0000000..d237ead
>> --- /dev/null
>> +++ b/tests/docker/test-build
>> @@ -0,0 +1,18 @@
>> +#!/bin/bash -e
>> +#
>> +# Quick compiling test that everyone already does. But why not automate it?
>> +#
>> +# Copyright (c) 2016 Red Hat Inc.
>> +#
>> +# Authors:
>> +#  Fam Zheng <address@hidden>
>> +#
>> +# This work is licensed under the terms of the GNU GPL, version 2
>> +# or (at your option) any later version. See the COPYING file in
>> +# the top-level directory.
>> +
>> +. common.rc
>> +
>> +DEF_TARGET_LIST="$(echo {x86_64,aarch64}-softmmu)"
>
> Like I said in v1, better flatten this to "x86_64-softmmu,aarch64-softmmu" as 
> it
> is in test-quick now.

oops, sorry missed that. Will fix.

>
> Fam
>
>> +TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
>> +build_qemu
>> --
>> 2.9.3
>>


--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]