[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link |
Date: |
Wed, 12 Oct 2016 15:37:21 +0200 |
On Wed, 12 Oct 2016 00:12:48 -0700
Li Qiang <address@hidden> wrote:
> From: Li Qiang <address@hidden>
>
> In v9fs_link dispatch function, it doesn't put the 'oldfidp'
> fid object, this will make the 'oldfidp->ref' never reach to 0,
> thus leading a memory leak issue. This patch fix this.
>
> Signed-off-by: Li Qiang <address@hidden>
> ---
Good catch!
Reviewed-by: Greg Kurz <address@hidden>
> hw/9pfs/9p.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index 8b50bfb..29f8b7a 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -2413,6 +2413,7 @@ static void v9fs_link(void *opaque)
> if (!err) {
> err = offset;
> }
> + put_fid(pdu, oldfidp);
> out:
> put_fid(pdu, dfidp);
> out_nofid: