[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/10] ui: remove misleading comment from vnc_init_st
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 01/10] ui: remove misleading comment from vnc_init_state |
Date: |
Thu, 13 Oct 2016 11:32:49 +0200 |
From: "Daniel P. Berrange" <address@hidden>
The last line in vnc_init_state() says
/* vs might be free()ed here */
This was added in
commit 198a0039c5fca224a77e9761e2350dd9cc102ad0
Author: Gerd Hoffmann <address@hidden>
Date: Tue Jun 16 14:19:48 2009 +0200
vnc: rework VncState release workflow.
because the preceeding 'vnc_update_client()' could indeed
release the VncState instance.
The call to vnc_update_client() was removed not long after
though in
commit 1fc624122fb923c7fc4c1f426541d953e7df13c9
Author: Stefano Stabellini <address@hidden>
Date: Mon Aug 3 10:54:32 2009 +0100
single vnc server surface
and so the comment has been wrong ever since
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 76a3273..5faf79b 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3092,8 +3092,6 @@ void vnc_init_state(VncState *vs)
vs->mouse_mode_notifier.notify = check_pointer_type_change;
qemu_add_mouse_mode_change_notifier(&vs->mouse_mode_notifier);
-
- /* vs might be free()ed here */
}
static gboolean vnc_listen_io(QIOChannel *ioc,
--
1.8.3.1
- [Qemu-devel] [PULL 00/10] ui: vnc cleanups, input-linux kbd fix., Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 01/10] ui: remove misleading comment from vnc_init_state,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 07/10] ui: remove bogus call to reset_keys() in vnc_init_state, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 10/10] input-linux: initialize key state, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 03/10] ui: remove 'ws_tls' field from VncState, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 04/10] ui: rename misleading 'VncDisplay' variables, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 06/10] ui: remove bogus call to graphic_hw_update() in vnc_listen_io, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 05/10] ui: refactor method for setting up VncDisplay auth types, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 08/10] ui: move some initialization out of vnc_init_state, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 02/10] ui: remove 'enabled' and 'ws_enabled' fields from VncState, Gerd Hoffmann, 2016/10/13
- [Qemu-devel] [PULL 09/10] ui: rename vnc_init_state to vnc_start_protocol, Gerd Hoffmann, 2016/10/13
- Re: [Qemu-devel] [PULL 00/10] ui: vnc cleanups, input-linux kbd fix., Peter Maydell, 2016/10/13