Re: [Qemu-devel] [PATCH 2/4] pc: Register TYPE_PC_MACHINE properties as class properties

[Igor Mammedov]

On Thu, 13 Oct 2016 18:26:40 -0300
Eduardo Habkost <address@hidden> wrote:

> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  hw/i386/pc.c | 56 ++++++++++++++++++++++++++------------------------------
>  1 file changed, 26 insertions(+), 30 deletions(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 93ff49c..f4b0cda 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
[...]
> +    object_class_property_add(oc, PC_MACHINE_MEMHP_REGION_SIZE, "int",
> +        pc_machine_get_hotplug_memory_region_size, NULL,
> +        NULL, NULL, &error_abort);

Not related to this patch but might be TODO item.
Perhaps we should get rid of this property as it's used only internally
by build_srat() which has direct access to PCMachineState.

>  }
>  
>  static const TypeInfo pc_machine_info = {