[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 13/35] tcg: Add atomic helpers
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v6 13/35] tcg: Add atomic helpers |
Date: |
Sun, 16 Oct 2016 23:23:37 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sun, Oct 16, 2016 at 18:40:05 -0700, Richard Henderson wrote:
> On 10/16/2016 03:17 PM, Emilio G. Cota wrote:
> >>+#if DATA_SIZE == 1
> >>> +# define END
> >>> +#elif defined(HOST_WORDS_BIGENDIAN)
> >>> +# define END _be
> >>> +#else
> >>> +# define END _le
> >>> +#endif
> >It took me a while to figure out that ATOMIC_NAME needs END (ATOMIC_NAME
> >is defined later in the patch).
> >
> >It might be clearer to pass it explicitly as a suffix in the macro, as in
> >#define ATOMIC_NAME(name, suffix) to then have ATOMIC_NAME(cmpxchg, END).
>
> Hum. Perhaps a comment?
Yep that would do as well.
Emilio
- [Qemu-devel] [PATCH v6 12/35] cputlb: Tidy some macros, (continued)
- [Qemu-devel] [PATCH v6 12/35] cputlb: Tidy some macros, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 16/35] tcg: Emit barriers with parallel_cpus, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 14/35] tcg: Add atomic128 helpers, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 15/35] tcg: Add CONFIG_ATOMIC64, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 13/35] tcg: Add atomic helpers, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 17/35] target-i386: emulate LOCK'ed cmpxchg using cmpxchg helpers, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 19/35] target-i386: emulate LOCK'ed INC using atomic helper, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 18/35] target-i386: emulate LOCK'ed OP instructions using atomic helpers, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 21/35] target-i386: emulate LOCK'ed NEG using cmpxchg helper, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 20/35] target-i386: emulate LOCK'ed NOT using atomic helper, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 22/35] target-i386: emulate LOCK'ed XADD using atomic helper, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 23/35] target-i386: emulate LOCK'ed BTX ops using atomic helpers, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 24/35] target-i386: emulate XCHG using atomic helper, Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 25/35] target-i386: remove helper_lock(), Richard Henderson, 2016/10/11
- [Qemu-devel] [PATCH v6 26/35] tests: add atomic_add-bench, Richard Henderson, 2016/10/11