[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/15] tcg: Minor adjustments to deposit expande
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH 02/15] tcg: Minor adjustments to deposit expanders |
Date: |
Mon, 17 Oct 2016 17:23:37 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 16.10.2016 05:37, Richard Henderson wrote:
> Assert that len is not 0.
>
> Since we have asserted that ofs + len <= N, a later
> check for len == N implies that ofs == 0.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/tcg-op.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
> index cc4a331..39bab98 100644
> --- a/tcg/tcg-op.c
> +++ b/tcg/tcg-op.c
> @@ -543,10 +543,11 @@ void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1,
> TCGv_i32 arg2,
> TCGv_i32 t1;
>
> tcg_debug_assert(ofs < 32);
> + tcg_debug_assert(len > 0);
> tcg_debug_assert(len <= 32);
> tcg_debug_assert(ofs + len <= 32);
>
> - if (ofs == 0 && len == 32) {
> + if (len == 32) {
> tcg_gen_mov_i32(ret, arg2);
> return;
> }
> @@ -1693,10 +1694,11 @@ void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1,
> TCGv_i64 arg2,
> TCGv_i64 t1;
>
> tcg_debug_assert(ofs < 64);
> + tcg_debug_assert(len > 0);
> tcg_debug_assert(len <= 64);
> tcg_debug_assert(ofs + len <= 64);
>
> - if (ofs == 0 && len == 64) {
> + if (len == 64) {
> tcg_gen_mov_i64(ret, arg2);
> return;
> }
>
Reviewed-by: Claudio Fontana <address@hidden>
- [Qemu-devel] [PATCH 00/15] tcg field extract primitives, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 01/15] tcg: Add field extraction primitives, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 03/15] tcg/aarch64: Implement field extraction opcodes, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 02/15] tcg: Minor adjustments to deposit expanders, Richard Henderson, 2016/10/15
- Re: [Qemu-devel] [PATCH 02/15] tcg: Minor adjustments to deposit expanders,
Claudio Fontana <=
- [Qemu-devel] [PATCH 04/15] tcg/arm: Move isa detection to tcg-target.h, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 05/15] tcg/arm: Implement field extraction opcodes, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 06/15] tcg/i386: Implement field extraction opcodes, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 07/15] tcg/mips: Implement field extraction opcodes, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 08/15] tcg/ppc: Implement field extraction opcodes, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 09/15] tcg/s390: Implement field extraction opcodes, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 10/15] target-alpha: Use deposit and extract ops, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 11/15] target-arm: Use tcg_gen_*extract, Richard Henderson, 2016/10/15
- [Qemu-devel] [PATCH 12/15] target-i386: Use tcg_gen_extract_tl, Richard Henderson, 2016/10/15